Break out metadata/info about an extension from the interface #16118
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ajcvickers
requested review from
roji,
AndriySvyryd and
bricelam
and removed request for
roji and
AndriySvyryd
src/EFCore.Relational/Infrastructure/RelationalOptionsExtension.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Jun 17, 2019
ajcvickers
force-pushed
the
WalkOnTheWildSide0616
branch
from
b79f8f5
to
96aa70b
Compare
ghost
deleted the
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also stop calling ApplyServices to find out if an extension is a database provider.
Fixes #16119
Fixes #16045
Doing this refactoring because we keep having to add/change methods here, so putting them in a composed abstract base class to avoid breaking the interface each time.