Query: Materialize results of FirstOrDefault in subquery only when th… #18693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smitpatel
force-pushed
the
smit/firstOrDefault
branch
from
493bb25
to
0f1d8f1
Compare
AndriySvyryd
reviewed
Nov 1, 2019
AndriySvyryd
reviewed
Nov 1, 2019
test/EFCore.Specification.Tests/Query/GearsOfWarQueryTestBase.cs
Outdated
Show resolved
Hide resolved
AndriySvyryd
approved these changes
Nov 1, 2019
maumar
reviewed
Nov 1, 2019
maumar
reviewed
Nov 1, 2019
maumar
approved these changes
Nov 1, 2019
…ere are rows Issue: When we generate translation for subquery.FirstOrDefault() using Left join, we get null in values when there is no associated record. Then we try to create result with default values rather than returning default of result type. Fix: Whenever we go through path where we are adding subquery.FirstOrDefault in projection, we inject 1 as dummy column. If we see 1 in result then only we materialize the object else we return default of the type. - For entityTypes this is not needed because we return null if key values are null. - For scalar which is server eval (i.e. only 1 column), we generate projectionBinding using resultType so we will get correct default back. - For scalar result which is client eval, we inject 1 into client projections. - For non scalar results (anonymous/nominal types), in client/server eval case, we inject 1 into projection/projectionMapping. Resolves #17287
smitpatel
force-pushed
the
smit/firstOrDefault
branch
from
0f1d8f1
to
64b8642
Compare
|
cc: @Pilchie |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ere are rows
Issue: When we generate translation for subquery.FirstOrDefault() using Left join, we get null in values when there is no associated record.
Then we try to create result with default values rather than returning default of result type.
Fix: Whenever we go through path where we are adding subquery.FirstOrDefault in projection, we inject 1 as dummy column. If we see 1 in result then only we materialize the object else we return default of the type.
Resolves #17287