Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Improve error handling when things fail on the command line #119

Closed
Praburaj opened this issue Apr 24, 2014 · 3 comments
Closed

Improve error handling when things fail on the command line #119

Praburaj opened this issue Apr 24, 2014 · 3 comments
Assignees
Milestone

Comments

@Praburaj
Copy link
Contributor

[On Helios]:
[On CoreCLR]:
Starting yesterday's build, I'm seeing that any compilation error in a C# file (say Startup.cs) is not being displayed on the command line. The Helios error page simply displays a FileLoadException Application.dll

[On DesktopCLR]:
No compilation errors being printed on command line, but the Helios error page shows the compilation errors

[Selfhost]: klr.exe crashes when application has a compilation error. Apart from that I see the same problem with respect to compilation errors listed.
[OnCoreCLR]: The compilation errors are swallowed and I can only see klr.exe crashing with a FileNotFound exception on application.dll
[DesktopClr]: The compilation errors are listed and klr.exe crashes.

Expectation:

  1. Compilation errors bubbled up in CoreClr.
  2. klr.exe should not crash instead just show the compilation errors and gracefully stop.
@Praburaj Praburaj added this to the Alpha milestone Apr 24, 2014
@Praburaj Praburaj added the bug label Apr 24, 2014
@davidfowl davidfowl self-assigned this Apr 25, 2014
@davidfowl
Copy link
Member

The bug in core clr was fixed (bug on their end). The k bubbling the exception is new. We can handle that in the right layer.

@Praburaj
Copy link
Contributor Author

Praburaj commented May 8, 2014

This fix should also address the case when k.cmd is being run on a folder without project.json it should exit gracefully without the error message we print now.

@davidfowl davidfowl modified the milestones: Post Alpha, Alpha May 14, 2014
@davidfowl davidfowl changed the title Compilation errors not displayed in CoreCLR Improve error handling when things fail on the command line May 16, 2014
@davidfowl
Copy link
Member

Updated the title

@danroth27 danroth27 modified the milestones: CTP1, Alpha, CTP2 May 20, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants