You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.
Assemblies do not currently contain an AssemblyFileVersion attribute. This attribute is used by Windows Installer to determine whether or not a file can be upgraded.
We should add something like DNX_ASSEMBLY_FILE_VERSION
Any installer that consumes these will be broken when doing upgrades from one build to the next as files could be skipped.
The text was updated successfully, but these errors were encountered:
Here is a proposal that's not for the two PRs that I sent because they go in the release branch. It is for the dev branch.
I don't think that the Roslyn compiler should have this logic embedded in it.The file version and the commit hash should be compiler preprocess steps added by the app. But, instead of adding the preprocess step to each project, we could either add it to global.json (does that work today?) or have an environment variable that specifies extra folders to look for compiler process files. So, KoreBuild would included these preprocess steps and apps consume them.
Assemblies do not currently contain an AssemblyFileVersion attribute. This attribute is used by Windows Installer to determine whether or not a file can be upgraded.
We should add something like DNX_ASSEMBLY_FILE_VERSION
Any installer that consumes these will be broken when doing upgrades from one build to the next as files could be skipped.
The text was updated successfully, but these errors were encountered: