Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

Don't use environment variables to pass data from native to managed code #1970

Closed
davidfowl opened this issue May 28, 2015 · 8 comments
Closed
Assignees
Milestone

Comments

@davidfowl
Copy link
Member

It flows to child contexts and generally messes things up.

@muratg
Copy link
Contributor

muratg commented May 28, 2015

@moozzyk

@blowdart
Copy link
Member

Bonus potential security issues here as well :)

@moozzyk
Copy link
Contributor

moozzyk commented May 28, 2015

Fixing AppDomainManager may be interesting

@moozzyk
Copy link
Contributor

moozzyk commented Jul 17, 2015

When doing this we should also pass OS, Architecture etc. from the native layer to managed code.

@analogrelay
Copy link
Contributor

Also the framework name selected using the --framework switch specified in #2333. Right now I'm going to be repurposing the DNX_FRAMEWORK environment variable to do this.

This one might be tricky since it needs to get to the DomainManager. Possibly a P/Invoke callback could be used?

@davidfowl
Copy link
Member Author

Related to #2544. When you make this change, can you make it so that https://github.com/aspnet/dnx/blob/dev/src/Microsoft.Dnx.Host/Bootstrapper.cs has a richer object model that represents the things it takes as input? Basically a higher level hosting API that doesn't assume the caller is a command line application?

@moozzyk
Copy link
Contributor

moozzyk commented Sep 22, 2015

@davidfowl
Copy link
Member Author

This must have the record for most commits associated with bugs

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants