Skip to content
This repository has been archived by the owner on Dec 18, 2017. It is now read-only.

"dnu publish" should restore for wrapper projects before building them #2352

Closed
ChengTian opened this issue Jul 27, 2015 · 2 comments
Closed
Assignees
Milestone

Comments

@ChengTian
Copy link
Contributor

@davidfowl

Today when doing dnu publish, we implicitly "no-source" wrapper projects. That is, for a project.json wrapping a csproj, we always build nupkg from it, no matter --no-source option was given or not.

However, there is no dnu restore being done before we call dnu publish. So when you dnu publish a project referencing a wrapped csproj, building the wrapper project will be failed.

capture

Or we want to call dnu restore during dnu wrap?

@ChengTian
Copy link
Contributor Author

I suggest that we restore during dnu publish instead of dnu wrap because only the publishing scenario needs a lock file.

@sayedihashimi
Copy link

Looking forward to the fix in beta8. Please let me know if this moves out as its impacting VS scenarios.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants