Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Class placement issues according to Clean Architecture #6

Open
HybridSolutions opened this issue Dec 14, 2023 · 0 comments
Open

Class placement issues according to Clean Architecture #6

HybridSolutions opened this issue Dec 14, 2023 · 0 comments

Comments

@HybridSolutions
Copy link

HybridSolutions commented Dec 14, 2023

Hi,

Interesting project! Have a couple of questions concerning some choices in the project.

Placing the IAppLogger interface in the Domain layer does not seem aligned with the typical responsibilities of the Domain layer in Clean Architecture. The Domain layer is primarily responsible for encapsulating the core business logic and domain entities. Logging is generally considered an infrastructure concern, and exposing logging interfaces in the Domain layer could violate the separation of concerns.

Why did you place that interface in the Core/Domain layer?

Also, Application Layer usually defines interfaces that are implemented by the outer layers, so why are repository interfaces inside the Core Layer and not the Application Layer? You seem to implement them in the Infrastructure layer as recommended so I'm not getting this choice.

Thank you

@HybridSolutions HybridSolutions changed the title IAppLogger Interface placement according to Clean Architecture Class placement issues according to Clean Architecture Dec 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant