Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

beamforming.py uses removed torch.complex32 #608

Closed
ben-freist opened this issue Mar 16, 2022 · 3 comments
Closed

beamforming.py uses removed torch.complex32 #608

ben-freist opened this issue Mar 16, 2022 · 3 comments
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@ben-freist
Copy link
Contributor

ben-freist commented Mar 16, 2022

Before reporting a bug:

First, please search previous issues
and the FAQ and be sure this hasn't
been answered elsewhere.

🐛 Bug

torch temporarily removed torch32 for some fixes (pytorch/pytorch#72721), it'll be brought back in a later version.

To Reproduce

Steps to reproduce the behavior (code sample and stack trace):

  • checkout the asteroid repo
  • pip install -e .
  • python -m pytest tests/dsp/beamforming_test.py
============================================================================================ short test summary info =============================================================================================
ERROR tests/dsp/beamforming_test.py - AttributeError: module 'torch' has no attribute 'complex32'
!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!! Interrupted: 1 error during collection !!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!!
================================================================================================ 1 error in 2.00s ================================================================================================

Expected behavior

The test should pass.

Environment

With python 3.6 an older torch version is used but both python3.7.12 and python3.9.10 give. me this problem.

Package versions

My commit is 25b03c7 on master.

@ben-freist ben-freist added bug Something isn't working help wanted Extra attention is needed labels Mar 16, 2022
@john7rho
Copy link

john7rho commented Jun 6, 2022

hello, i was wondering if there were any work-arounds for this? i believe the speech separation also does not work on versions past python3.6, but i may be mistaken.

@mpariente
Copy link
Collaborator

Yes, sorry, I haven't looked into this issue. I'll have a look in the coming weeks.

@mpariente
Copy link
Collaborator

Closed by #609

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

3 participants