From a7c533634dc1f45a545b10595769c69d5c8582e6 Mon Sep 17 00:00:00 2001 From: Micha Reiser Date: Sun, 19 Feb 2023 13:18:47 +0100 Subject: [PATCH] chore: Remove `default_members` from `Cargo.toml` (#3006) This PR removes the `default_members` from the workspace configuration. ## Why I'm not familiar with the motivation for why the `default_members` setting was added initially, and I do not object to keeping it. I'll explain my motivation for removing it below. My main reason for removing the `default_members` override is that new contributors may not know that `cargo test`, `cargo build`, and other commands only run on a subset of crates. They may then be surprised that their PRs are failing in CI, but everything works locally. My guess why `default_members` was added is to speed up the development workflow. That's fair, but I question the value because `ruff` is the heaviest crate to build. --- Cargo.toml | 1 - 1 file changed, 1 deletion(-) diff --git a/Cargo.toml b/Cargo.toml index 590d46014efb8..f89714d1b245d 100644 --- a/Cargo.toml +++ b/Cargo.toml @@ -1,6 +1,5 @@ [workspace] members = ["crates/*"] -default-members = ["crates/ruff", "crates/ruff_cli"] [workspace.dependencies] anyhow = { version = "1.0.66" }