Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SEP-10: apply grace period to minTime constraint #212

Closed
JakeUrban opened this issue Sep 17, 2021 · 1 comment · Fixed by #256
Closed

SEP-10: apply grace period to minTime constraint #212

JakeUrban opened this issue Sep 17, 2021 · 1 comment · Fixed by #256
Assignees

Comments

@JakeUrban
Copy link
Contributor

SEP-10: Apply grace period to minTime constraint

It is possible that the client machine's clock is behind the SEP-10 server machine's clock.

If this is the case, client applications calling readChallengeTx() may not be able to validate the challenge due to the challenge transaction's minimum timebound being greater than the client machine's current time.

Changes

readChallengeTx() or the equivalent function

  • Apply a 5-minute grace period to the minibum timebound check
    • i.e. the minimum timebound should be permitted to be at most 5 minutes in the future from the client machine's current time

Implementations

Both the JS and Go SDKs have been updated with these changes.

@JakeUrban
Copy link
Contributor Author

@JakeUrban JakeUrban changed the title SEP-10: apply grace period to minTime constraint (SDF) SEP-10: apply grace period to minTime constraint Sep 29, 2021
@charlie-wasp charlie-wasp self-assigned this Feb 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants