Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop importing/exposing everything that can be used by end-users in Cosmos __init__ #1213

Open
tatiana opened this issue Sep 23, 2024 · 3 comments
Labels
area:config Related to configuration, like YAML files, environment variables, or executer configuration breaking-change To consider for major releases
Milestone

Comments

@tatiana
Copy link
Collaborator

tatiana commented Sep 23, 2024

The current approach is very error-prone:
https://github.com/astronomer/astronomer-cosmos/blob/aa26fc35b7caf5e456e1d582ebab4056c5bfb34f/cosmos/__init__.py

People who add new execution modes have to change multiple places, and the tendency is for this module to grow indefinitely. We should stop doing this and clean up what we want to expose from within the root path of Cosmos.

@tatiana tatiana added this to the Cosmos 2.0.0 milestone Sep 23, 2024
@dosubot dosubot bot added the area:config Related to configuration, like YAML files, environment variables, or executer configuration label Sep 23, 2024
@pankajkoti
Copy link
Contributor

Should we create a label saying breaking-change and attach to such issues?

@tatiana
Copy link
Collaborator Author

tatiana commented Sep 23, 2024

I think this is a great suggestion, @pankajkoti , could you do this, please?

@pankajkoti pankajkoti added the breaking-change To consider for major releases label Sep 23, 2024
@pankajkoti
Copy link
Contributor

Thanks @tatiana for the agreement. I have created a label and attached to the ones that I felt are breaking changes(most of them already had Cosmos 2.0.0 milestone set). Rethinking, I feel this could be duplicacy to setting the Milestone 2.0.0, but let's see if it is of any help to also have that label. If we think it's not needed, we can delete that label.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:config Related to configuration, like YAML files, environment variables, or executer configuration breaking-change To consider for major releases
Projects
None yet
Development

No branches or pull requests

2 participants