Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor custom project parsing so Python models have dedicated method #384

Closed
tatiana opened this issue Jul 23, 2023 · 1 comment
Closed

Comments

@tatiana
Copy link
Collaborator

tatiana commented Jul 23, 2023

In order to implement support to Python models in #375 we reused some existing methods from the legacy Project codebase to support Python models when using LoadMode.CUSTOM. The goal with this ticket is to refactor the code so we have adequate code coverage and Python models are parsed with a dedicated method, and not _handle_sql_file, as discussed in:
#375 (comment)

Copy link

dosubot bot commented Nov 9, 2023

Hi, @tatiana. I'm Dosu, and I'm helping the Cosmos team manage their backlog. I wanted to let you know that we are marking this issue as stale.

From what I understand, you opened this issue suggesting a refactoring of the custom project parsing in order to have a separate method for parsing Python models. This would avoid reusing existing methods. However, there hasn't been any activity or comments on the issue since then.

Could you please let us know if this issue is still relevant to the latest version of the Cosmos repository? If it is, please comment on the issue to let the Cosmos team know. Otherwise, feel free to close the issue yourself, or the issue will be automatically closed in 7 days.

Thank you for your understanding and contribution to the Cosmos repository.

@dosubot dosubot bot added the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 9, 2023
@dosubot dosubot bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2023
@dosubot dosubot bot removed the stale Issue has not had recent activity or appears to be solved. Stale issues will be automatically closed label Nov 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant