Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Model selection "plus" operator not properly parsed when selecting tags #823

Closed
Tracked by #1103
enkeboll opened this issue Jan 30, 2024 · 7 comments · Fixed by #1150
Closed
Tracked by #1103

Model selection "plus" operator not properly parsed when selecting tags #823

enkeboll opened this issue Jan 30, 2024 · 7 comments · Fixed by #1150
Assignees
Labels
area:selector Related to selector, like DAG selector, DBT selector, etc dbt:run Primarily related to dbt run command or functionality epic-assigned execution:local Related to Local execution environment parsing:custom Related to custom parsing, like custom DAG parsing, custom DBT parsing, etc triage-needed Items need to be reviewed / assigned to milestone
Milestone

Comments

@enkeboll
Copy link

Migrating an issue raised in the #airflow-dbt slack org:
image
image

Basically, the "plus" operator isn't properly parsed when used with tags. So tag:every-hour works but +tag:every-hour or tag:every-hour+ result in empty graphs. We use this syntax in our DBT Cloud scheduled jobs, even though it isn't explicitly called out in the DBT docs:
image

I'm happy to try to take a stab at adding this functionality to selector.py, unless there's a reason to hold off.

Copy link

dosubot bot commented Jan 30, 2024

🤖

That's a great initiative! Your willingness to take a stab at adding this functionality to selector.py is much appreciated. Your contribution would definitely be valuable to the community. Thank you for considering this and feel free to reach out if you need any guidance along the way.


This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@dosubot dosubot bot added area:selector Related to selector, like DAG selector, DBT selector, etc dbt:run Primarily related to dbt run command or functionality execution:local Related to Local execution environment parsing:custom Related to custom parsing, like custom DAG parsing, custom DBT parsing, etc labels Jan 30, 2024
@jbandoro
Copy link
Collaborator

jbandoro commented Jan 31, 2024

Thanks @enkeboll for opening this issue!

I'm happy to try to take a stab at adding this functionality to selector.py, unless there's a reason to hold off.

That would be great, thanks! Let us know if you need any support.

@danielvdende
Copy link
Contributor

Any update on this? We just hit the same issue 🥲

@enkeboll
Copy link
Author

I personally haven't started work on this yet, though it's still in my backlog.

@tatiana tatiana added this to the 1.5.0 milestone May 17, 2024
@tatiana tatiana added the triage-needed Items need to be reviewed / assigned to milestone label May 17, 2024
@tatiana
Copy link
Collaborator

tatiana commented May 17, 2024

@enkeboll @danielvdende, would you have bandwidth to work on this?

@tatiana tatiana self-assigned this May 17, 2024
@tatiana tatiana mentioned this issue May 17, 2024
@gbatiz
Copy link

gbatiz commented May 27, 2024

Would it be possible to for the development team to pick this up?

We are making use of custom node renderers for sources (sensor to wait on loading task) and exposures (operator triggering refresh in BI-tool), but schedule-related tags only make sense in case models.

We would like to run models tagged daily in a daily Airflow DAG, models tagged weekly in a weekly DAG, etc.
However, without properly functioning graph selectors, we cannot include sources and exposures for these models.

We have quite extensive workarounds for now to make this work, but would like to get rid of them.

@tatiana
Copy link
Collaborator

tatiana commented Aug 14, 2024

It seems @mvictoria is solving the issue in #1150 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:selector Related to selector, like DAG selector, DBT selector, etc dbt:run Primarily related to dbt run command or functionality epic-assigned execution:local Related to Local execution environment parsing:custom Related to custom parsing, like custom DAG parsing, custom DBT parsing, etc triage-needed Items need to be reviewed / assigned to milestone
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants