Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add continuous performance benchmarking to Cosmos #868

Open
jbandoro opened this issue Feb 28, 2024 · 1 comment
Open

Add continuous performance benchmarking to Cosmos #868

jbandoro opened this issue Feb 28, 2024 · 1 comment
Labels
area:performance Related to performance, like memory usage, CPU usage, speed, etc dbt:parse Primarily related to dbt parse command or functionality execution:local Related to Local execution environment parsing:custom Related to custom parsing, like custom DAG parsing, custom DBT parsing, etc
Milestone

Comments

@jbandoro
Copy link
Collaborator

After performance integration tests were added in #827 a reasonable follow-up would be to integrate a tool like github-action-benchmark to have continuous benchmarking of Cosmos performance so that possible performance improvements or regressions by comparing benchmark results can be detected.

The work would involve using pytest-benchmark to output the performance benchmark results and then storing the results with the GH action like in the example here. We could setup alerts for PRs.

A follow-up to this could also involve benchmarking the DAG parsing times for various load methods, e.g. LoadMode.DBT_LS and LoadMode.DBT_MANIFEST to track performance for parsing.

Copy link

dosubot bot commented Feb 28, 2024

🤖

That sounds like a great idea! Continuous performance benchmarking can definitely help in identifying performance improvements or regressions. Using github-action-benchmark and pytest-benchmark seems like a good approach. Your proposal to also benchmark the DAG parsing times for various load methods is a valuable addition. We encourage you to go ahead and create a pull request for this feature. Your contribution will be much appreciated!

About Dosu

This response is meant to be useful and save you time. It is not meant to be a precise solution, but rather a starting point for your own research.

Help me be more useful! Please leave a 👍 if this is helpful and 👎 if it is irrelevant.

If you want to continue the conversation, start your reply with @dosu-bot.

@dosubot dosubot bot added area:performance Related to performance, like memory usage, CPU usage, speed, etc dbt:parse Primarily related to dbt parse command or functionality execution:local Related to Local execution environment parsing:custom Related to custom parsing, like custom DAG parsing, custom DBT parsing, etc labels Feb 28, 2024
@tatiana tatiana added this to the 1.6.0 milestone May 17, 2024
@tatiana tatiana modified the milestones: Cosmos 1.6.0, Cosmos 1.7.0 Jul 5, 2024
@tatiana tatiana modified the milestones: Cosmos 1.7.0, Triage Sep 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:performance Related to performance, like memory usage, CPU usage, speed, etc dbt:parse Primarily related to dbt parse command or functionality execution:local Related to Local execution environment parsing:custom Related to custom parsing, like custom DAG parsing, custom DBT parsing, etc
Projects
None yet
Development

No branches or pull requests

2 participants