Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtractOutputPreprocessor isn't being used by nbcollection? #547

Open
jonathansick opened this issue Apr 1, 2022 · 2 comments
Open

ExtractOutputPreprocessor isn't being used by nbcollection? #547

jonathansick opened this issue Apr 1, 2022 · 2 comments

Comments

@jonathansick
Copy link
Contributor

In #530 we enabled the ExtractOutputPreprocessor (which extracts figures from html files, thereby making them something that the UI can source in the cards). However, this doesn't seem to actually be running. If you look at any rendered-tutorials artifact, the figures are definitely still embedded.

Are traits not getting passed by nbcollection to nbconvert? Any ideas @adrn?

Now, we can work around this by having Learn Astropy Librarian extract the figures and put them on some static file host (while doing some sort of resizing and optimization... which we may need to do regardless), however, it'd be good to understand what's going on here.

@adrn
Copy link
Member

adrn commented Apr 7, 2022

Hm, not sure! I can look into this next week

@adrn
Copy link
Member

adrn commented Apr 14, 2022

I think this commit will fix the issue: astropy/nbcollection@a1101ef

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants