Skip to content
This repository has been archived by the owner on Oct 17, 2024. It is now read-only.

Consider updating miniconda version #353

Closed
bsipocz opened this issue Nov 29, 2018 · 5 comments
Closed

Consider updating miniconda version #353

bsipocz opened this issue Nov 29, 2018 · 5 comments

Comments

@bsipocz
Copy link
Member

bsipocz commented Nov 29, 2018

4.5.11 now comes with python3.7 and as we use that as default more and more places it would make sense to avoid one more python install.

@djhoese
Copy link
Contributor

djhoese commented Mar 13, 2019

I was just about to make an issue for this, but conda 4.6 is available (not through miniconda installer yet). More importantly 4.6.3 fixes an issue where package "activation" scripts are now run after the package is installed. Without this packages like pyproj don't have their environment variables set correctly unless you deactivate and reactivate the test environment.

Would it be possible to include a conda update conda command in ci-helpers? See conda-forge/pyproj-feedstock#29 for details.

@bsipocz
Copy link
Member Author

bsipocz commented Mar 13, 2019

You can have any conda version number you like, just use CONDA_VERSION in the travis config. We deliberately don't upgrade to the latest as it caused numerous issues in the past.

@djhoese
Copy link
Contributor

djhoese commented Mar 13, 2019

Is that documented somewhere? I don't see it in the README?

@djhoese
Copy link
Contributor

djhoese commented Mar 13, 2019

Also is there a way to say "the latest version"?

@bsipocz
Copy link
Member Author

bsipocz commented Mar 13, 2019

Hmm, there are missing pieces here and there. If you have time to open a PR, it would be more than welcome for both the README and the latest version.

E.g. changing the logic to something like:

if [[ -z $CONDA_VERSION ]]; then
    CONDA_VERSION=4.5.12
elif [[ $CONDA_VERSION == latest ]] || [[ $CONDA_VERSION == stable ]]; then
    CONDA_VERSION=
fi

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants