You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While implementing a few queries I stumbled across some corrections/improvements that could be made to the in-code documentation. No doubt there are plenty of others, and a thorough review wouldn't be a bad idea, but here is a start:
Replace the reference to a nonexistent 'database' search with a reference to TAP.
Says that self.search() is equivalent to self.to_service().search(), but to_service() doesn't exist. It should be just service(), which is a little inconsistent with RegistryResults where table() has been deprecated in favor of to_table().
Has 2 different descriptions for size argument, neither of which are very clear about what you can/should supply. (This function doc is repeated multiple places in sia.py.)
Documents the intersect argument which is not required for SIA services and probably isn't well-supported. The docs should at least have that caveat.
While implementing a few queries I stumbled across some corrections/improvements that could be made to the in-code documentation. No doubt there are plenty of others, and a thorough review wouldn't be a bad idea, but here is a start:
pyvo/pyvo/registry/regtap.py
Line 330 in 96443be
self.search()
is equivalent toself.to_service().search()
, butto_service()
doesn't exist. It should be justservice()
, which is a little inconsistent with RegistryResults wheretable()
has been deprecated in favor ofto_table()
.pyvo/pyvo/dal/query.py
Line 426 in 96443be
pyvo/pyvo/dal/sia.py
Line 188 in 96443be
size
argument, neither of which are very clear about what you can/should supply. (This function doc is repeated multiple places in sia.py.)intersect
argument which is not required for SIA services and probably isn't well-supported. The docs should at least have that caveat.pyvo/pyvo/dal/query.py
Line 291 in 96443be
The text was updated successfully, but these errors were encountered: