Documentation for SIA2: How are units supposed to be specified?

[keflavich]

pyvo/pyvo/dal/sia2.py

Lines 33 to 42 in 4a6f52f

	SIA2_PARAMETERS_DESC = """
	pos : single or list of tuples
	angle units (default: deg)
	the positional region(s) to be searched for data. Each region can
	be expressed as a tuple representing a CIRCLE, RANGE or POLYGON as
	follows:
	(ra, dec, radius) - for CIRCLE. (angle units - defaults to)
	(long1, long2, lat1, lat2) - for RANGE (angle units required)
	(ra, dec, ra, dec, ra, dec ... ) ra/dec points for POLYGON all
	in angle units

There are a few problems with the docstring here:
" (ra, dec, radius) - for CIRCLE. (angle units - defaults to) " defaults to what? Presumably degrees?

" (long1, long2, lat1, lat2) - for RANGE (angle units required) "
Does this mean that the user must specify angle units? How? i.e., are these strings or astropy units?

[bsipocz]

+1 for fixing the docstrings.

you should be able to feed in an astropy angle, and skycoords, if not, then those are bugs.