-
-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: SDSS remote data not found (404), failing 6 tests #1135
Comments
I don't have any insider knowledge from SDSS, but I know this server goes up and down some of the time - not the first time this particular source of data has been 404ing. (But the last time I remember this happening it was down for a while, like days or maybe even weeks until someone realized it...) |
Is there a more stable source? |
I have a vague memory of a "better" URL that essentially goes for the same place but sometimes falls back on something else that is against a more modern API instead of direct URL? But I don't remember much more than that. Maybe @weaverba137 or @havok2063 have insight here (I could be just imagining this, but I think one of them might have been the person to tell me this)? |
Oh, wait, I think I found part of it - the suggested solution was to use the SAS server: https://dr17.sdss.org/optical/spectrum/search - the problem was that it doesn't expose exactly the same data, and I think we couldn't figure out exactly how to get the same spectra. So the test would have to be re-written for a different file (which is not impossible but is non-trivial work) |
Some of the tests that are failing use this url, Other tests that are failing use this old url, |
I believe a simple http-> https replacement will fix issues with das.sdss.org. |
It looks like the das server is back up as of right sometime in the last ~ hour... but the http -> https shift is probably a good idea anyway!
I wonder if that means we should just grab that one example file and host it somewhere else? I don't think we want to deprecate the reader itself because there's still plenty of these files out there for various science use cases, but if they're not "officially" being served, we shouldn't have the tests depend on that as the authoritative copy. |
No the spSpec files definitely still exist. Just follow the link & you'll see them. |
Thanks! I confirmed locally that just upgrading to HTTPS works, so I opened #1136 |
Example log: https://github.com/astropy/specutils/actions/runs/8994189000/job/24707287554
The text was updated successfully, but these errors were encountered: