You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Some issues are lingering from #273 with respect to how meta should behave when a SpectrumCollection is created from multiple Spectrum1D objects. See #273 (comment) and follow-on comments for more discussion. The core question: how should they be "indexed"? More specifically:
Should the keys be (i, j, ..) to match the ? Or should the dict be ordered (either implicity or explicitly) so that meta.values()[i,j,...] do the right thing?
Should the meta instead not even be a nested set of dicts, but rather be merged? This could be an optional keyword to add to the SpectrumCollection.from_spectra method.
The text was updated successfully, but these errors were encountered:
If the WCS for SpectrumCollection is going to be a list of individual WCS's, then I think it makes sense for the meta to be a list of individual meta's. Since the spectra themselves are not in dictionaries, think it could cause confusion if these other objects are, since then you can't slice them with the same indices.
Arguably one might want to have one meta for the SpectrumCollection as well as a meta for each spectrum in the collection (akin to the header 0 and the individual extension headers in multi-extension FITS files). Packaging them in a dictionary with the list of individual metas just being one item in the dictionary seems okay, but would make the call for getting a particular metadata value look different for Spectrum collection meta['individual_meta'][3]['keyword'] for the fourth spectrum in the collection vs. meta['keyword'] for the Spectrum1D case. But I think that's okay.
The logic for merging meta could be a mess, depending on the contents of the metadata.
Some issues are lingering from #273 with respect to how
meta
should behave when aSpectrumCollection
is created from multipleSpectrum1D
objects. See #273 (comment) and follow-on comments for more discussion. The core question: how should they be "indexed"? More specifically:(i, j, ..)
to match the ? Or should the dict be ordered (either implicity or explicitly) so thatmeta.values()[i,j,...]
do the right thing?meta
instead not even be a nested set of dicts, but rather be merged? This could be an optional keyword to add to theSpectrumCollection.from_spectra
method.The text was updated successfully, but these errors were encountered: