Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Priority system in loaders no longer works #584

Closed
nmearl opened this issue Feb 11, 2020 · 3 comments
Closed

Priority system in loaders no longer works #584

nmearl opened this issue Feb 11, 2020 · 3 comments
Labels

Comments

@nmearl
Copy link
Contributor

nmearl commented Feb 11, 2020

Loaders are assigned priorities and they should be taken into consideration when conflicts arise amongst potential loaders when a format is not explicitly give.

@nmearl nmearl added the bug label Feb 11, 2020
@dhomeier
Copy link
Contributor

Those are passed as kwarg to data_loader, right? But where are they (supposed to be) assigned? I'd expect they might be written into the @data_loader decorators, but can't find one that has a priority value or seems to have had one in recent times...

@nmearl
Copy link
Contributor Author

nmearl commented Feb 17, 2020

The loader priorty is stored here, but it looks like we need to be more specific about using it (before, it seemed that the order in the registry was part of the determination for which loader to choose). It seems at some point, we took them out during a refactor.

I'm imagining that we'll want to find all loaders that meet the identifier criteria. If there is more than one, simply compare priorities and return the appropriate loader.

@aragilar
Copy link
Contributor

aragilar commented Sep 7, 2021

This is fixed by #757.

@rosteen rosteen closed this as completed Sep 7, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants