Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

specutils should not globally set enabled equivalencies #671

Closed
astrofrog opened this issue May 3, 2020 · 1 comment
Closed

specutils should not globally set enabled equivalencies #671

astrofrog opened this issue May 3, 2020 · 1 comment
Labels
bug

Comments

@astrofrog
Copy link
Member

astrofrog commented May 3, 2020 •
edited
Loading

Currently, importing specutils causes spectral equivalencies to be enabled by default for the rest of the Python session:

specutils/specutils/spectra/spectrum1d.py

Line 18 in ca093ea

u.set_enabled_equivalencies(u.spectral())

This should be removed, and the equivalencies should only be enabled temporarily in the context where they are used (currently the astropy test suite breaks if specutils is installed because of this: astropy/astropy#10283)
@astrofrog astrofrog added the bug label May 3, 2020
@astrofrog astrofrog mentioned this issue May 3, 2020
Closed
@dhomeier dhomeier mentioned this issue May 7, 2020
Merged
@nmearl
Copy link
Contributor

nmearl commented Jun 3, 2020 •
edited
Loading

Fixed in #673.

@nmearl nmearl closed this as completed Jun 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@astrofrog @nmearl