Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Broken on Nightly #2

Open
CommCody opened this issue Jun 22, 2012 · 3 comments
Open

Broken on Nightly #2

CommCody opened this issue Jun 22, 2012 · 3 comments

Comments

@CommCody
Copy link

Hi, here I am again.
Just to say it's broken on nightly (only noticed now, but probably already longer).

(Build: Mozilla/5.0 (Windows NT 6.1; rv:16.0) Gecko/16.0 Firefox/16.0a1 ID:20120621053048)

ps: I will at this here, but if there is help I can do (help) let me know and I will see wath I can do (but mind that I'm only starting on add-on/javascript developmentm I come from a C#/java background)

@asutherland
Copy link
Owner

Yes, I just noticed it yesterday. It's not entirely surprising. I'm aware that the following changes have been made in regards to the memory reporters:

  • I believe the string arrangement of compartments has changed. It's quite possible this has broken my parsing code.
  • It's possible that some of the reporter hierarchies were also re-arranged, which would also break things quickly, but be a fairly easy fix, I think/hope.
  • One-compartment-per-global has landeded, so there's a looot of compartments now. I would expect this to slow things down (because there's so much more to process), and make the origin aggregation logic distribute the blame when it should no longer do so. Previously, there would only be one JS compartment per origin, so we would need to apportion the blame for that compartment over all the webpages in that origin. (Where origin is the DNS host and port of the website.)

The first two should be fairly easy to address; the latter one is more involved.

A related issue is that the code for about:memory, which lib/memfrob.js is derived from, has been changed since I copied it and modified it.

Unfortunately, I'm going to very busy for the next 2 weeks and definitely won't be able to do any work on this myself. However, I would be very happy to provide you with feedback/advice if you do want to go ahead and investigate/fix things. lib/memfrob.js is really the only file I think you'd need to hack on.

@CommCody
Copy link
Author

Ok I would like to investigate, unfortunatly with other things demanding my constant attention I'm not entirely sure I will get to it.

I will keep you posted of what I find

@asutherland
Copy link
Owner

Understood. I'll post here if I have time to look into it so that we don't duplicate any effort.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants