Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite Barrier using WakerSet #565

Closed
yoshuawuyts opened this issue Nov 20, 2019 · 3 comments · Fixed by #581
Closed

Rewrite Barrier using WakerSet #565

yoshuawuyts opened this issue Nov 20, 2019 · 3 comments · Fixed by #581
Labels
enhancement New feature or request

Comments

@yoshuawuyts
Copy link
Contributor

The broadcaster library has taken us very far, but unfortunately has dependencies on futures_channel. Now that we have WakerSet available internally (for now still, see #549) we should probably consider rewriting Barrier to use it.

It should both improve our compilation times, and performance. This would put us in a place where we could consider stabilizing the API. Thanks!

cc/ @tmccombs @stjepang

Refs

@yoshuawuyts yoshuawuyts added the enhancement New feature or request label Nov 20, 2019
@tmccombs
Copy link
Contributor

I can take a stab at this.

@leo60228
Copy link

You could implement futures_sink::Sink for async_std::sync::Sender to get rid of the futures_channel dependency. That would require committing to the Sink API in async-std, though.

@yoshuawuyts
Copy link
Contributor Author

@leo60228 we have no plans to include Sink in async-std currently. I believe #581 would close this issue, and is currently pending a review by @stjepang.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants