Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add file output for TypeScript generator #536

Merged
merged 27 commits into from
Jan 7, 2022
Merged

feat: add file output for TypeScript generator #536

merged 27 commits into from
Jan 7, 2022

Conversation

jonaslagoni
Copy link
Member

Description
This PR adds file output for the TypeScript generator.

Related issue(s)
Fixes #399

@coveralls
Copy link

coveralls commented Dec 21, 2021 •
edited
Loading

Pull Request Test Coverage Report for Build 1667630293

  • 33 of 33 (100.0%) changed or added relevant lines in 6 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.05%) to 93.304%
Totals Coverage Status
Change from base Build 1658755179: 0.05%
Covered Lines: 2351
Relevant Lines: 2400
💛 - Coveralls

@jonaslagoni jonaslagoni mentioned this pull request Dec 28, 2021
Closed
@jonaslagoni jonaslagoni mentioned this pull request Jan 4, 2022
Merged
@jonaslagoni
Copy link
Member Author

Blocked by #557

@jonaslagoni
Copy link
Member Author

I really hate windows and Linux differences.......... 🙄

tsc --downlevelIteration -t es5 ${path.resolve(renderOutputPath, './*.ts')} works fine in linux... However, windows only works with tsc --downlevelIteration -t es5 --baseUrl ${renderOutputPath}....

@jonaslagoni jonaslagoni mentioned this pull request Jan 5, 2022
Merged
magicmatatjahu
magicmatatjahu previously approved these changes Jan 7, 2022
View reviewed changes
src/generators/typescript/TypeScriptGenerator.ts Outdated Show resolved Hide resolved
@sonarcloud
Copy link

sonarcloud bot commented Jan 7, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@jonaslagoni
Copy link
Member Author

Thanks @magicmatatjahu !

@jonaslagoni jonaslagoni merged commit 5cbe362 into asyncapi:master Jan 7, 2022
@jonaslagoni jonaslagoni deleted the feature/typescript_file_output branch January 7, 2022 13:30
@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 0.42.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@asyncapi-bot
Copy link
Contributor

🎉 This PR is included in version 1.0.0-next.23 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@magicmatatjahu magicmatatjahu Awaiting requested review from magicmatatjahu magicmatatjahu is a code owner

Assignees
No one assigned
Labels
released on @next released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Generating TypeScript models directly to files
4 participants
@jonaslagoni @coveralls @asyncapi-bot @magicmatatjahu