feat: add dart generator. #658
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
rmasarovic
force-pushed
the
feature/dart-generator
branch
from
8ca20db
to
c4f2a55
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
Pull Request Test Coverage Report for Build 2236282726
💛 - Coveralls |
There was a problem hiding this comment.
Awesome @rmasarovic 🎉
The only thing missing is tests and docs!
- We need to add a Dart specific documentation for the JSON preset you added: https://github.com/asyncapi/modelina/tree/master/docs/languages
- We need to add an example for the Dart JSON preset, read more about how to add it here: https://github.com/asyncapi/modelina/blob/master/docs/contributing.md#adding-examples
- We need to add the basic usage example for Dart to the docs: https://github.com/asyncapi/modelina/blob/master/docs/usage.md
- We need to add Dart to the main readme: https://github.com/asyncapi/modelina#features
Furthermore, we need to add tests to cover at least the current test coverage (93%).
Feel free to ping me if you get stuck!
…ture/dart-generator2 # Conflicts: # examples/generate-dart-models/package-lock.json # examples/generate-dart-models/package.json
rmasarovic
requested review from
magicmatatjahu and
asyncapi-bot-eve
as code owners
|
@jonaslagoni hi i try to add documentation and tests maybe now it will be good |
There was a problem hiding this comment.
@jonaslagoni hi i try to add documentation and tests maybe now it will be good
This is so awesome!
I have absolutely no comments for it 🔥
Only a final remark, would you like to champion and maintain the Dart generator or are you only interested in contributing it? 🙂 Feel free to ping me on slack when you have considered it or have any questions 🙇
|
/rtm |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@all-contributors please add @rmasarovic for code, docs, test, example |
|
I've put up a pull request to add @rmasarovic! 🎉 |
|
🎉 This PR is included in version 0.57.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 1.0.0-next.23 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Description