feat: add isOldAsyncAPIDocument helper #687
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magicmatatjahu
requested review from
fmvilas,
jonaslagoni,
derberg and
asyncapi-bot-eve
as code owners
jonaslagoni
reviewed
Dec 8, 2022
There was a problem hiding this comment.
Do you want to add a converter as well? I.e. from old parser document to new version? The code you send works:
// Is from old parser
const parsedJSON = input.json();
const detailed = createDetailedAsyncAPI(parsedJSON, parsedJSON);
doc = createAsyncAPIDocument(detailed);
|
one cent from me, please update readme where we document all custom parser extensions |
|
@jonaslagoni I can add but it won't work in 100% cases. |
|
Kudos, SonarCloud Quality Gate passed!
|
|
@jonaslagoni Done Could you check again? |
jonaslagoni
reviewed
Dec 9, 2022
jonaslagoni
approved these changes
Dec 9, 2022
derberg
approved these changes
Dec 13, 2022
|
/rtm |
|
🎉 This PR is included in version 2.0.0-next-major.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
x-parser-api-versionto have info about parser-api used in AsyncAPI modelisOldAsyncAPIDocumenthelper function to check if document use old apiisAsyncAPIDocumentcc @jonaslagoni as you want :)