Parser 2.0 does not validate channel name

[ivangsa]

Describe the bug

Parser 2.0 has a bug and do not validate channel name

How to Reproduce

This was reported here
asyncapi/vs-asyncapi-preview#166

Expected behavior

It return a validation error like version 1.x:

6.TestChannel?Content-Type=application/json;charset=utf-8 channel contains invalid name with url query parameters: ?Content-Type=application/json;charset=utf-8

[github-actions]

Welcome to AsyncAPI. Thanks a lot for reporting your first issue. Please check out our contributors guide and the instructions about a basic recommended setup useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.

[derberg]

my guess is that https://github.com/asyncapi/parser-js/blob/master/lib/customValidators.js#L424 is not reflected in spectral rules for Parser 2 RC

[magicmatatjahu]

ParserJS v2 validates it, but it's treated as warning, not error - when you put the mentioned AsyncAPI document you will see this:

[derberg]

Yeah, but that is an error, spec says there SHALL NOT be query params. Parser 1 throws error, we should not have regression here. In case of custom validators from version 1 I remember that there was only once case where instead of error we should show warning

[magicmatatjahu]

So it's only a changing the severity kind of given rule, in this place - https://github.com/asyncapi/parser-js/blob/next-major/src/ruleset/v2/ruleset.ts#L290

[derberg]

@magicmatatjahu should it also be move under v2CoreRuleset ?

[magicmatatjahu]

Can be moved.

[derberg]

What needs to be done to solve:

Add severity: 'error' to https://github.com/asyncapi/parser-js/blob/next-major/src/ruleset/v2/ruleset.ts#L290 and move it under v2CoreRuleset

/gfi ts

[asyncapi-bot]

Hey @derberg, your message doesn't follow the requirements, you can try /help.

[smoya]

A PR with the fix has been created #747