fix: skip message object example validation for non default schemaFormats #778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
schemaFormats Signed-off-by: Chris Patmore <[email protected]>
chrispatmore
requested review from
fmvilas,
magicmatatjahu,
jonaslagoni,
derberg,
smoya and
asyncapi-bot-eve
as code owners
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Welcome to AsyncAPI. Thanks a lot for creating your first pull request. Please check out our contributors guide useful for opening a pull request.
Keep in mind there are also other channels you can use to interact with AsyncAPI community. For more details check out this issue.
|
Kudos, SonarCloud Quality Gate passed!
|
|
FYI raised the fix @jonaslagoni |
|
Sorry @chrispatmore, too many notifications, thanks for the ping 👍 |
|
/rtm |
|
🎉 This PR is included in version 2.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Small change to skip the validation of message example objects when a
schemaFormatisset. This allows the parser to validate schemas with non default schemaFormats that are also
providing examples.
This does mean if anyone manually sets
schemaFormatto the default the examples will notbe checked. Also it does not validate the examples against the schema for non default formats
so they may be incompatible
Related issue(s)
Fixes #772