fix: null check when checking schemaFormat in array items #786
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
due to a quirk of how nimma generates the evaluation logic for checking fields in objects inside an array whilst filtering it is possible to get an npe. Adding specific checks against this. Contributes to: asyncapi#784 Signed-off-by: Chris Patmore <[email protected]>
chrispatmore
requested review from
fmvilas,
magicmatatjahu,
jonaslagoni,
derberg,
smoya and
asyncapi-bot-eve
as code owners
chrispatmore
commented
Jun 13, 2023
| @@ -31,6 +31,7 @@ export function testRule(ruleName: RuleNames, tests: Scenario,): void { | |||
| const doc = JSON.stringify(testCase.document); | |||
|
|
|||
| const errors = await parser.validate(doc); | |||
| expect(errors.filter(({ code }) => code === 'uncaught-error')).toHaveLength(0); | |||
There was a problem hiding this comment.
test wasn't seeing the uncaught errors which threw me for a long time
| @@ -123,17 +123,17 @@ export const v2CoreRuleset = { | |||
| given: [ | |||
| // messages | |||
| '$.channels.*.[publish,subscribe].[?(@property === \'message\' && @.schemaFormat === void 0)]', | |||
| '$.channels.*.[publish,subscribe].message.oneOf[?(@.schemaFormat === void 0)]', | |||
| '$.channels.*.[publish,subscribe].message.oneOf[?(!@null && @.schemaFormat === void 0)]', | |||
There was a problem hiding this comment.
just null check anywhere we are checking the value of a property inside an object
|
Kudos, SonarCloud Quality Gate passed!
|
|
/rtm |
|
🎉 This PR is included in version 2.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
due to a quirk of how nimma generates the evaluation logic for checking fields in objects inside an array whilst filtering it is possible to get an npe. Adding specific checks against this.
Related issue(s)
Fixes #784