Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved Decoder Selection #153

Closed
jchrys opened this issue Oct 6, 2023 · 1 comment · Fixed by #263
Closed

Improved Decoder Selection #153

jchrys opened this issue Oct 6, 2023 · 1 comment · Fixed by #263
Assignees
@mirromutth
Labels
enhancement New feature or request good first issue Good for newcomers
Milestone
1.1.3

Comments

@jchrys
Copy link
Collaborator

jchrys commented Oct 6, 2023

Is your feature request related to a problem? Please describe.
We currently find an appropriate decoder iteratively, which is slow and inefficient. This process could be significantly optimized.

Describe the solution you'd like
Implementing a fast path for decoder selection using map. This would streamline the decoder selection process, leading to improved performance and efficiency.
@jchrys jchrys added the enhancement New feature or request label Oct 6, 2023
@jchrys jchrys modified the milestones: 1.0.5/0.9.6, 1.0.6/0.9.7 Oct 6, 2023
@mirromutth
Copy link
Contributor

We can make a fast path for default types, just like mariadb-connector-r2dbc does.

@jchrys jchrys modified the milestones: 1.0.6/0.9.7, 1.1.0/0.10.0 Dec 21, 2023
@jchrys jchrys added the good first issue Good for newcomers label Jan 11, 2024
@jchrys jchrys modified the milestones: 1.1.0/0.10.0, 1.0.7/0.9.8 Jan 18, 2024
@jchrys jchrys modified the milestones: 1.1.0/0.10.0, 1.1.1 Feb 7, 2024
@mirromutth mirromutth modified the milestones: 1.1.2, 1.1.3 Feb 22, 2024
@mirromutth mirromutth self-assigned this Mar 15, 2024
@mirromutth mirromutth mentioned this issue Mar 15, 2024
Merged
@mirromutth mirromutth linked a pull request Mar 15, 2024 that will close this issue
Add fast path for determining Codec #263
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mirromutth mirromutth

Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
1.1.3
Development

Successfully merging a pull request may close this issue.

Add fast path for determining Codec asyncer-io/r2dbc-mysql
2 participants
@mirromutth @jchrys