Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong URL checked? Includes query string in path #71

Open
hitsthings opened this issue Jan 16, 2024 · 0 comments
Open

Wrong URL checked? Includes query string in path #71

hitsthings opened this issue Jan 16, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@hitsthings
Copy link

Describe the bug
Just noticed that one of the URLs you hit for testing my Connect app includes a fake querystring in the path portion of the URL.

The URL you hit is /atlassian/project/test&canEditProject=true

To Reproduce
I have a jiraProjectPage with the following URL:
/atlassian/project/{project.key}/{project.id}/?canViewProject=true&project_key={project.key}&project_id={project.id}&canEditProject={condition.has_project_permission(permission=EDIT_ISSUES)}

Expected behavior
You probably want to test /atlassian/project/test?canEditProject=true so that you are testing the actual queryStringHash validation.

You probably would also want to use a real project key? Otherwise I think you just get 404s anyway?

Marketplace App Information
Include one of the following:

I don't need an update or anything - feel free to ignore this if I'm off. Just felt like you'd want to be doing something different.

@hitsthings hitsthings added the bug Something isn't working label Jan 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant