Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Name of scattering solver WSMs #717

Open
erikssonpatrick opened this issue Jan 9, 2024 · 1 comment
Open

Name of scattering solver WSMs #717

erikssonpatrick opened this issue Jan 9, 2024 · 1 comment
Labels
bug Issues that make the package feel broken

Comments

@erikssonpatrick
Copy link
Contributor

New WSM for DISORT is cloudbox_fieldDisort. Long name, but logical.

However, WSM names for RT4 and DOIT are not changed, e.g. being RT4Calc. This is not consistent and is causing confusion.

What pattern to follow? Old, concise or new, long, but more ARTSy.

@erikssonpatrick erikssonpatrick added the bug Issues that make the package feel broken label Jan 9, 2024
@riclarsson
Copy link
Contributor

It should follow the long logical name. This is a matter of communication and perhaps discovery. Browsing through a sorted list of method names, e.g., Workspace Methods, you should be able to find the method.

This is not really a change. The policy was always to have names like the long ones. This policy was just easy to ignore in the SVN way since there is not review-step.

As always, though, it's up to people that use these methods to fix them :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Issues that make the package feel broken
Projects
None yet
Development

No branches or pull requests

2 participants