Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Further cleaning around scat_species #98

Closed
erikssonpatrick opened this issue Oct 17, 2019 · 2 comments
Closed

Further cleaning around scat_species #98

erikssonpatrick opened this issue Oct 17, 2019 · 2 comments
Assignees
Milestone

Comments

@erikssonpatrick
Copy link
Contributor

Hi,

When looking in m_cloudbox for a method, I noticed some methods that got me to think. There are still some unclarities around scat_species.

First of all, it used in the new PSD system. Is scat_species a good name here? Should it be renamed to something like psd_id_string?

Further, the description of scat_species needs to be updated.

There are also some old methods that use scat_species:
ScatElementsSelect
ScatSpeciesExtendTemperature
ScatSpeciesMerge
Does that make sense now?

When looking at this, also these methods should be revised:
particle_fieldCleanup
ScatSpeciesInit
ScatElementsPndAndScatAdd
ScatSpeciesPndAndScatAdd
ScatElementsToabs_speciesAdd
ScatSpeciesScatAndMetaRead

Do we need all these now? Good naming of the WSMs?

@erikssonpatrick
Copy link
Contributor Author

Will not be relevant after Simon's new system.

@erikssonpatrick
Copy link
Contributor Author

Should have pressed close for last comment!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants