Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Touch Bar integration broken (again) #325

Closed
jpcranford opened this issue Oct 16, 2020 · 7 comments · Fixed by #329
Closed

Touch Bar integration broken (again) #325

jpcranford opened this issue Oct 16, 2020 · 7 comments · Fixed by #329

Comments

@jpcranford
Copy link

Sometime between the fixes contained in #312 (i.e. a set of curly brackets in the /lib/touch-bar-manager.js file) and the release of v1.4.1, the support for Touch Bars broke... I think. I uninstalled and reinstalled this plugin and the issue persists.

Honestly I'm out of my depth, and if there's a debug/reloading step to take, please let me know.

@aminya
Copy link
Member

aminya commented Oct 16, 2020

@jpcranford Could you run apm install tool-bar and post the output?

@jpcranford
Copy link
Author

jpcranford commented Oct 17, 2020

Okay, after it gave me some grief because of too many aliases, I fixed that and finally got this result:

username_redacted@computer ~ % apm install tool-bar
Installing tool-bar to /Users/ldsmadman/.atom/packages ✓

I mean, I'm no programmer but I think this means it installed successfully, right? It didn't fix anything though

@aminya
Copy link
Member

aminya commented Oct 17, 2020

This shows that the package is installed correctly.

@suda Did you build-commit before publishing?

@suda
Copy link
Collaborator

suda commented Nov 5, 2020

@aminya yep, it's now a part of my release process.

I no longer have an MBP with a touch bar so I'm not able to debug it either. I'll mark this as "help needed" in case anyone else can help.

@ThatXliner
Copy link
Member

ThatXliner commented Nov 28, 2020

I have the same issue too. It won't show the icons

@GRA0007
Copy link

GRA0007 commented Mar 18, 2021

Note that this is being addressed here: #329

@aminya
Copy link
Member

aminya commented Jun 7, 2021

Fixed in 1.4.4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants