Skip to content
This repository has been archived by the owner on Dec 15, 2022. It is now read-only.

Unclear what the grey cross icon stands for #25

Open
vemv-kantox opened this issue Jun 10, 2015 · 4 comments
Open

Unclear what the grey cross icon stands for #25

vemv-kantox opened this issue Jun 10, 2015 · 4 comments

Comments

@vemv-kantox
Copy link

Right now I can't reproduce it sorry, but sometimes when I resolve a keybinding, it looks successfully resolved (points to the right function) but a grey cross appears instead of a green tick.

I don't know what that means. Issue in the keybinding? In the function itself?

I'd expect a error message to appear, or at least if I hover over the cross, a generic description of the issue.

Thanks - Victor

@izuzak
Copy link
Contributor

izuzak commented Jun 17, 2015

@vemv-kantox The grey ✖️ is an unmatched keybinding. These are keybindings which have the same keystroke, but were not matched because you didn't use them in the right context.

For example, when I focus the text editor and press a, this is shown in the keybinding resolver:

screen shot 2015-06-17 at 19 04 57

The deprecation keybinding resolver shows a single keybinding, the one for the tree-view:add-file command, which is bound to the key a and is valid when the element matches this selector: .tree-view. Since the target element (the editor) doesn't match that selector -- the keybinding didn't match even though I pressed the right keystroke a.

And if I press a when the tree view is focused, the keybinding resolver shows this, because the selector and keystroke matched:

screen shot 2015-06-17 at 19 21 07

Does that explain things? I agree it would be useful to have this documented somewhere, so I'll keep this open to remind us to do that.

@vemv-kantox
Copy link
Author

Now it's clear, thanks! Documenting the feature could be as simple as adding a brief explanation in the UI itself.

@mnquintana
Copy link
Contributor

Certainly wouldn't hurt to add a tooltip 👍

@RexYuan
Copy link

RexYuan commented Dec 1, 2015

Spent some time to find here. Maybe I'm more obtuse to realize its meaning, but it'd be nice to have this information more accessible! Like at least in the README

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants