Error in C syntax coloring on string literal

[rshamsnejad]

Edit by @rsese to add alternate example with 1.42.0-nightly6 on macOS 10.14.6

#define SQLITE_UNIX_CURRENT_TS "hello"
#define MINUTE "world"

int main() {
  char *s = "WHERE timestamp < " SQLITE_UNIX_CURRENT_TS " - (1 * " MINUTE ")";

  return 0;
}

" - (1 * " isn't treated as a string in this case.

With Tree-sitter disabled:

---

Prerequisites

• Put an X between the brackets on this line if you have done all of the following:
  • Reproduced the problem in Safe Mode: https://flight-manual.atom.io/hacking-atom/sections/debugging/#using-safe-mode
  • Followed all applicable steps in the debugging guide: https://flight-manual.atom.io/hacking-atom/sections/debugging/
  • Checked the FAQs on the message board for common solutions: https://discuss.atom.io/c/faq
  • Checked that your issue isn't already filed: https://github.com/issues?utf8=✓&q=is%3Aissue+user%3Aatom
  • Checked that there is not already an Atom package that provides the described functionality: https://atom.io/packages

Description

The following string literal in C breaks syntax coloring in Atom :

"WHERE timestamp < " SQLITE_UNIX_CURRENT_TS " - (1 * " MINUTE ")";

The only parts not between quotes are SQLITE_UNIX_CURRENT_TS and MINUTE. However, here is the result :

I am sure that this piece of code's syntax is correct, because it compiles without errors. The problem seems to be caused by the * operator of my SQL query, ie. the following code is correctly colored :

"WHERE timestamp < " SQLITE_UNIX_CURRENT_TS " - (1 " MINUTE ")";

As you can see :

However, removing the - operator breaks coloring in another way, ie. in the following code :

"WHERE timestamp < " SQLITE_UNIX_CURRENT_TS " (1 * " MINUTE ")";

Which yields the following :

Steps to Reproduce

1. Create an empty file with C syntax coloring
2. Paste the following code : "WHERE timestamp < " SQLITE_UNIX_CURRENT_TS " - (1 * " MINUTE ")";

Expected behavior:

Coloring as in the 2nd screenshot (but including the * operator)

Actual behavior:

Wrong coloring as in the 1st and 3rd screenshots.

Reproduces how often:

I have only seen this occurring on the exact piece of code stated in the "Steps to reproduce" section.

Versions

$ inxi -SCMG
System:    Host: rsd-vm-lmde Kernel: 4.9.0-11-amd64 x86_64 bits: 64 Desktop: Cinnamon 4.2.4 Distro: LMDE 3 Cindy 
Machine:   Type: Virtualbox System: innotek product: VirtualBox v: 1.2 serial: <root required> 
           Mobo: Oracle model: VirtualBox v: 1.2 serial: <root required> BIOS: innotek v: VirtualBox date: 12/01/2006 
CPU:       Topology: Quad Core model: Intel Core i5-8265U bits: 64 type: MCP L2 cache: 6144 KiB 
           Speed: 1800 MHz min/max: N/A Core speeds (MHz): 1: 1800 2: 1800 3: 1800 4: 1800 
Graphics:  Device-1: VMware SVGA II Adapter driver: vmwgfx v: 2.12.0.0 
           Display: x11 server: X.Org 1.19.2 driver: vmware unloaded: fbdev,modesetting,vesa resolution: 1920x950~60Hz 
           OpenGL: renderer: Gallium 0.4 on llvmpipe (LLVM 3.9 256 bits) v: 3.3 Mesa 13.0.6 
$ atom --version
Atom    : 1.40.1
Electron: 3.1.10
Chrome  : 66.0.3359.181
Node    : 10.2.0
$ apm --version
apm  2.4.3
npm  6.2.0
node 10.2.1 x64
atom 1.40.1
python 2.7.13
git 2.11.0

Additional Information

None that I can think of.

[rsese]

Thanks for the report! Does this seem like a good full minimal working example of the problem? I can reproduce the issue you described with this snippet but it's always helpful to have a self-contained minimal example so just wanted to double check.

#define SQLITE_UNIX_CURRENT_TS "hello"
#define MINUTE "world"

int main() {
  char *s = "WHERE timestamp < " SQLITE_UNIX_CURRENT_TS " - (1 * " MINUTE ")";

  return 0;
}

[rshamsnejad]

Hi Robert,

Yes, I confirm that your snippet compiles without errors, and produces the same syntax coloring issue :

Thanks !