Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Structural problems with code #96

Open
timcallow opened this issue Nov 13, 2021 · 0 comments
Open

Structural problems with code #96

timcallow opened this issue Nov 13, 2021 · 0 comments
Assignees

Comments

@timcallow
Copy link
Contributor

atoMEC currently relies on the config.py module to store various global variables. This worked ok for the initial purpose of the code, which was basically just set up to solve the KS-DFT equations for an average-atom model.

However, it's becoming clear to me that this a major problem when one wants to use the code in a modular way as more functionality is added, particularly post-processing tools for a given output of a KS calculation. Such issues are not limited to just the config.py module, some classes are initialized in such a way that it is not possible (without great difficulty) for a user to create their own instances, rather they only work if created via a KS-DFT calculation.

Fixing this issue will require a significant reformulation of the code... But needs to be done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant