-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow generator registrations to specify a starting point #425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[atomist:generated]
johnsonr
changed the title
Remove TODO
Allow generator registrations to specify a starting point
Jul 2, 2018
cdupuis
added
the
changelog:added
Add this issue or pull request to added changelog section
label
Jul 2, 2018
jessitron
approved these changes
Jul 2, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on #424 - please review after that
Allow
GeneratorRegistration
to include astartingPoint
, which can be a project or a seed repo. This is an alternative to using thesource
on the parameters object.This clarifies how generators work - starting point + transformation - and allows the starting point to be created in memory if desired.
In future, generators will probably be expressed directly this way rather than in function wrappers as in the Spring pack. (They can use the functions provided in such packs for their transformation.)
Examples:
and:
Backward compatible.