Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add typed Build goal to register Builder instances #506

Merged
merged 5 commits into from
Sep 3, 2018
Merged

Add typed Build goal to register Builder instances #506

merged 5 commits into from
Sep 3, 2018

Conversation

cdupuis
Copy link
Member

@cdupuis cdupuis commented Sep 3, 2018 •
edited
Loading

This allows to register Builder instances on the new Build typed goal.

new Build("build").with({ builder: nodeBuilder(...) });

cdupuis and others added 5 commits September 3, 2018 09:19
@cdupuis
Add typed Build goal
90ca600
@atomist-bot
Autofix: TypeScript header
9e7659d 
[atomist:generated] [atomist:autofix=TypeScript header]
@atomist-bot
Autofix: tslint
4d2f0e3 
[atomist:generated] [atomist:autofix=tslint]
@cdupuis
Fix name conflict
98149f5
@atomist-bot
Autofix: tslint
3654a92 
[atomist:generated] [atomist:autofix=tslint]
@cdupuis cdupuis changed the title Autofix: tslint Add typed Build goal to register Builder instances Sep 3, 2018
@cdupuis cdupuis added changelog:added Add this issue or pull request to added changelog section auto-merge:on-approve Auto-merge on review approvals auto-merge-method:squash Auto-merge with squash and merge labels Sep 3, 2018
lievendoclo
lievendoclo approved these changes Sep 3, 2018
View reviewed changes
Copy link
Contributor

@lievendoclo lievendoclo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atomist-bot
Copy link
Contributor

Pull request auto merged by Atomist.

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot merged commit 165861e into master Sep 3, 2018
@atomist-bot atomist-bot deleted the typed-build-goal branch September 3, 2018 07:49
atomist-bot added a commit that referenced this pull request Sep 3, 2018
@atomist-bot
Changelog: #506 to added
03315a5 
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lievendoclo lievendoclo lievendoclo approved these changes

Assignees
No one assigned
Labels
auto-merge:on-approve Auto-merge on review approvals auto-merge-method:squash Auto-merge with squash and merge changelog:added Add this issue or pull request to added changelog section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdupuis @atomist-bot @lievendoclo