Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose structure of push tests and push rules #558

Merged
merged 35 commits into from
Oct 29, 2018

Conversation

johnsonr
Copy link
Contributor

@johnsonr johnsonr commented Oct 25, 2018

This functionality is important to allow better visualization of expected SDM activity and the generation of workflow plans for that subset of behavior that can be statically determined.

Also deletes obsolete deploy DSL.

Rod Johnson and others added 28 commits October 24, 2018 09:55
[atomist:generated] [atomist:autofix=typescript header]
[atomist:generated] [atomist:autofix=tslint]
[atomist:generated] [atomist:autofix=typescript imports]
because I don't think Rod will like looking at it in the tests
[atomist:generated] [atomist:autofix=typescript header]
[atomist:generated] [atomist:autofix=typescript imports]
[atomist:generated] [atomist:autofix=typescript imports]
because whatever is mutating it needs to not
we probably want to remove the visitor that it was testing
[atomist:generated] [atomist:autofix=typescript imports]
@johnsonr johnsonr requested a review from cdupuis October 25, 2018 04:36
atomist-bot and others added 6 commits October 25, 2018 05:14
[atomist:generated] [atomist:autofix=typescript imports]
deconstruct a MappingPushMapping
[atomist:generated] [atomist:autofix=typescript imports]
@cdupuis cdupuis added changelog:added Add this issue or pull request to added changelog section auto-merge:on-approve Auto-merge on review approvals auto-merge-method:squash Auto-merge with squash and merge labels Oct 29, 2018
Copy link
Member

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT

@atomist-bot
Copy link
Contributor

Pull request auto merged by Atomist.

  • 1 approved review by @cdupuis
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot merged commit c24f6aa into master Oct 29, 2018
@atomist-bot atomist-bot deleted the pushtest-structure-more branch October 29, 2018 21:50
atomist-bot added a commit that referenced this pull request Oct 29, 2018
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge:on-approve Auto-merge on review approvals auto-merge-method:squash Auto-merge with squash and merge changelog:added Add this issue or pull request to added changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants