Add fetchGoalsFromPush method to read goals from subscription #559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdupuis
force-pushed
the
goals-in-subscription
branch
from
638e44f
to
fb07e5e
Compare
cdupuis
added
changelog:added
cdupuis
force-pushed
the
goals-in-subscription
branch
from
e94e7f0
to
26798f1
Compare
[atomist:generated] [atomist:autofix=typescript header]
ddgenome
reviewed
Oct 25, 2018
| @@ -35,6 +35,14 @@ import { | |||
| import { goalKeyString } from "./sdmGoal"; | |||
| import { goalCorrespondsToSdmGoal } from "./storeGoals"; | |||
|
|
|||
| export function fetchGoalsFromPush(sdmGoal: SdmGoalEvent): SdmGoalEvent[] { | |||
| const goals = sumSdmGoalEvents((sdmGoal.push as any).goals.filter(g => g.goalSetId === sdmGoal.goalSetId)); | |||
There was a problem hiding this comment.
Is sdmGoal.push not typed?
There was a problem hiding this comment.
It is typed to a different type. Internally we are using subscription types but the API is using public SdmGoalEvent.
| "description": "Build successful", | ||
| "goalSetId": "c2e95b8a-61a5-4474-95de-7d918d0b5478", | ||
| "preApproval": null, | ||
| "preCondit |
| "description": "Build successful", | ||
| "goalSetId": "c2e95b8a-61a5-4474-95de-7d918d0b5478", | ||
| "preApproval": null, | ||
| "preCondit |
There was a problem hiding this comment.
Suggested change
| "preCondit | |
| assert(goals.every(g => g.push)); |
| @@ -14,7 +14,7 @@ | |||
| * limitations under the License. | |||
| */ | |||
|
|
|||
| import assert = require("power-assert"); | |||
| import * as assert from "power-assert"; | |||
ddgenome
approved these changes
Oct 25, 2018
|
Pull request auto merged by Atomist.
[atomist:generated] [auto-merge:on-approve] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.