Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add WellKnownGoals #566

Merged
merged 2 commits into from
Nov 1, 2018
Merged

Add WellKnownGoals #566

merged 2 commits into from
Nov 1, 2018

Conversation

johnsonr
Copy link
Contributor

@johnsonr johnsonr commented Nov 1, 2018

Add a type that can be used by extension packs that work with well known goals. Intended to help create consistency between extension packs and naming within SDM instances.

Using naming in sdm-pack-spring and sdm-pack-node.

Rod Johnson and others added 2 commits November 1, 2018 17:59
Add WellKnownGoals
00d60f5
@atomist-bot
Autofix: tslint
62f7328 
[atomist:generated] [atomist:autofix=tslint]
@cdupuis cdupuis self-requested a review November 1, 2018 07:31
@cdupuis cdupuis added changelog:added Add this issue or pull request to added changelog section auto-merge:on-approve Auto-merge on review approvals auto-merge-method:squash Auto-merge with squash and merge labels Nov 1, 2018
cdupuis
cdupuis reviewed Nov 1, 2018
View reviewed changes
Copy link
Member

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good idea.

Should that interface be added to the index?

cdupuis
cdupuis approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sdm creates the index using barrellsby. Nevermind my comment.

@atomist-bot
Copy link
Contributor

Pull request auto merged by Atomist.

  • 1 approved review by @cdupuis
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot merged commit ea4c9a2 into master Nov 1, 2018
@atomist-bot atomist-bot deleted the well-known-goals branch November 1, 2018 10:36
atomist-bot added a commit that referenced this pull request Nov 1, 2018
@atomist-bot
Changelog: #566 to added
73ac0f0 
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdupuis cdupuis cdupuis approved these changes

Assignees

@cdupuis cdupuis

Labels
auto-merge:on-approve Auto-merge on review approvals auto-merge-method:squash Auto-merge with squash and merge changelog:added Add this issue or pull request to added changelog section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@johnsonr @atomist-bot @cdupuis