Expose push to inspection and autofixes and remove broken considerOnlyChangedFiles option #568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[atomist:generated] [atomist:autofix=typescript header]
[atomist:generated] [atomist:autofix=tslint]
[atomist:generated] [atomist:autofix=typescript imports]
cdupuis
added
auto-merge:on-approve
|
Pull request auto merged by Atomist.
[atomist:generated] [auto-merge:on-approve] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
considerOnlyChangedFilesoption on inspections and autofixes does not work, and making it work would be unreasonably complex and flaky (necessitating temporarily hiding files on disk and fooling git). The responsibility of handling this should move to inspections and autofixes themselves.This PR exposes the
PushListenerInvocationto inspections and autofixes if they are invoked on a push in an optional property. This enables them to work with changed files etc.