-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for canceling goals #572
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refs #571
[atomist:generated] [atomist:autofix=tslint]
[atomist:generated] [atomist:autofix=typescript_header]
cdupuis
added
auto-merge:on-approve
Auto-merge on review approvals
auto-merge-method:squash
Auto-merge with squash and merge
changelog:added
Add this issue or pull request to added changelog section
labels
Nov 12, 2018
ddgenome
approved these changes
Nov 12, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. One question about a null check.
lievendoclo
reviewed
Nov 12, 2018
lievendoclo
approved these changes
Nov 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK
Pull request auto merged by Atomist.
[atomist:generated] [auto-merge:on-approve] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
auto-merge:on-approve
Auto-merge on review approvals
auto-merge-method:squash
Auto-merge with squash and merge
changelog:added
Add this issue or pull request to added changelog section
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for canceling goals:
This goal when added to a goal set will cancel all pending or in process auto fix, build, docker build and publish goal instances on the current goal's
push.before.sha
of the same branch.Which goals should be canceled can you be defined with the
goalFilter
onCancelOptions
:fixes #571