Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add review listeners that set goal result state #573

Merged
merged 1 commit into from
Nov 13, 2018

Conversation

ddgenome
Copy link
Contributor

Provide common review listeners that fail or require approval for
different review comments.

Fix automation-client peer dependency, although NPM semver still gets
it wrong. Update automation-client dev dependency and fix
compilation.

Remove GraphQL code generation peer dependencies and old schema files.

Update build package scripts.

Update ignored files.

Provide common review listeners that fail or require approval for
different review comments.

Fix automation-client peer dependency, although NPM semver still gets
it wrong.  Update automation-client dev dependency and fix
compilation.

Remove GraphQL code generation peer dependencies and old schema files.

Update build package scripts.

Update ignored files.
@ddgenome ddgenome added changelog:added Add this issue or pull request to added changelog section auto-merge:on-approve Auto-merge on review approvals labels Nov 13, 2018
Copy link
Member

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question... See inline

package.json Show resolved Hide resolved
@ddgenome ddgenome removed the request for review from lievendoclo November 13, 2018 21:30
@cdupuis cdupuis merged commit 96d00b9 into master Nov 13, 2018
@cdupuis cdupuis deleted the goal-review-listener branch November 13, 2018 22:01
atomist-bot added a commit that referenced this pull request Nov 13, 2018
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge:on-approve Auto-merge on review approvals changelog:added Add this issue or pull request to added changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants