Add ability to select goal based on push in DSL #642
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a
setGoalsWhen
method toGoalSetter
that allows choosing goals based on the push invocation. This combines with the recent introduction of stateful push invocations to allow previously computed state to be used in both goal choice and goal selection.The following example precomputes phases, attaches them as state to the invocation, and then chooses them on goal setting:
This change is backward compatible.
In this case the
GoalSetter
does not work as aStaticPushMapping
, making it impossible to predict all goals that will be set.