Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make goal launching more pluggable #656

Merged
merged 2 commits into from
Jan 14, 2019
Merged

Make goal launching more pluggable #656

merged 2 commits into from
Jan 14, 2019

Conversation

cdupuis
Copy link
Member

@cdupuis cdupuis commented Jan 14, 2019

This PR introduces an improved extension point for launching goals. Several GaolLauncher instances can be registered; the first which supports method returns true will launch the goal.

This is a change in public API, but I don't expect anybody to have implemented a custom IsolatedGoalLauncher at this point.

cdupuis and others added 2 commits January 14, 2019 16:40
@cdupuis
Rework goal launching
eccb49d
@atomist-bot
Autofix: TypeScript header
a9ee06e 
[atomist:generated] [atomist:autofix=typescript_header]
@cdupuis cdupuis added auto-merge:on-approve Auto-merge on review approvals changelog:changed Add this issue or pull request to changed changelog section labels Jan 14, 2019
@cdupuis cdupuis requested a review from ddgenome January 14, 2019 15:44
ddgenome
ddgenome approved these changes Jan 14, 2019
View reviewed changes
Copy link
Contributor

@ddgenome ddgenome left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@atomist-bot
Copy link
Contributor

Pull request auto merged by Atomist.

  • 1 approved review by @ddgenome
  • 2 successful checks

[atomist:generated] [auto-merge:on-approve]

@atomist-bot atomist-bot merged commit ae78c49 into master Jan 14, 2019
@atomist-bot atomist-bot deleted the goal-launching branch January 14, 2019 16:46
atomist-bot added a commit that referenced this pull request Jan 14, 2019
@atomist-bot
Changelog: #656 to changed
3f82814 
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ddgenome ddgenome ddgenome approved these changes

Assignees
No one assigned
Labels
auto-merge:on-approve Auto-merge on review approvals changelog:changed Add this issue or pull request to changed changelog section
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@cdupuis @atomist-bot @ddgenome