Provide a useful implementation of onTransformResults #666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cdupuis
reviewed
Jan 30, 2019
cdupuis
added
enhancement
This is one way to get some notification when the save failed
[atomist:generated] [atomist:autofix=typescript_header]
[atomist:generated] [atomist:autofix=typescript_imports]
jessitron
force-pushed
the
nortissej/onTransformResults
branch
from
6e6e2f6
to
d20ddd1
Compare
[atomist:generated] [atomist:autofix=typescript_imports]
|
@cdupuis like this? |
johnsonr
approved these changes
Feb 13, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is one way to get some notification when the save failed.
the story is: I made a transform with a colon in its name. When I ran it, it told me it was successful, because it didn't fail to edit the project. But it did fail to save those edits to a branch! It did not tell me!
Also it does not tell the branch when it succeeds; I have to go looking for it.
With this implementation of onTransformResults, I get a message in case of failure or success. It's very useful, I have wanted this a dozen times, and so it should be available in the library.