Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add project-aware goal invocation converter #697

Merged
merged 1 commit into from
Apr 1, 2019
Merged

Conversation

ddgenome
Copy link
Contributor

@ddgenome ddgenome commented Apr 1, 2019

This is useful when you want a ProjectAwareGoalInvocation but do not
want an ExecuteGoal.

Per https://github.com/atomist/docs-sdm/blob/08e0c738f35d21cd2bd87faa1b354a30c4b0dd98/lib/machine/htmltest.ts#L88

@ddgenome ddgenome added changelog:added Add this issue or pull request to added changelog section auto-merge:on-approve Auto-merge on review approvals auto-merge-method:merge Auto-merge with merge commit labels Apr 1, 2019
Copy link
Member

@cdupuis cdupuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably worth rev’ing the minor version too.

@ddgenome ddgenome removed the request for review from jessitron April 1, 2019 14:17
@ddgenome
Copy link
Contributor Author

ddgenome commented Apr 1, 2019

I'll rev the minor version in master and cut a release.

@ddgenome ddgenome merged commit a1b3571 into master Apr 1, 2019
@ddgenome ddgenome deleted the project-aware branch April 1, 2019 14:18
atomist-bot added a commit that referenced this pull request Apr 1, 2019
[atomist:generated]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
auto-merge:on-approve Auto-merge on review approvals auto-merge-method:merge Auto-merge with merge commit changelog:added Add this issue or pull request to added changelog section
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants